bazel-contrib / bazel-contrib/rules_scala

resource_strip_prefix doesn't work on windows

Open
#655 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
384
Forks
292
Avg merge
2d 22h
Merged PRs (30d)
47

Description

At least some of path handling is done based on strings, which breaks when running on windows. For example resource_strip_prefix:

https://github.com/bazelbuild/rules_scala/blob/da5ba6d97a1abdadef89d509b30a9dcfde7ffbe4/src/java/io/bazel/rulesscala/scalac/ScalacProcessor.java#L327-L331

For comparison here is how same code looks in Bazel:

https://github.com/bazelbuild/bazel/blob/6379ef5475217b3cf60038130cb83e4d45728b38/src/main/java/com/google/devtools/build/lib/rules/java/JavaHelper.java#L124-L135

Contributor guide

Open the contributing guide

Research direction

Start in src/java/io/bazel/rulesscala/scalac/ScalacProcessor.java at lines 327-331, then compare the path handling with Bazel's JavaHelper.java at lines 124-135. Investigate why resource_strip_prefix fails on Windows and verify that the behavior works correctly with Windows paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, scala
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.