bazel-contrib / bazel-contrib/rules_scala

single_line_to_string needs update

Open
#577 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Starlark
Stars
384
Forks
292
Avg merge
3d 28m
Merged PRs (30d)
40

Description

With ScalaPB 0.7, singleLineToString has been renamed to singleLineToProtoString. Just one line of code needs updating to be compatible with the latest ScalaPB:
https://github.com/bazelbuild/rules_scala/blob/958864711b3fe00045ac57b2ba86f709eeb8262d/scala_proto/scala_proto.bzl#L484

As it stands now, I get this error when building a scalapb_proto_library:
```
--scala_out: Unrecognized parameter: 'single_line_to_string'
ERROR: /.../BUILD.bazel:19:1: scala //protos/p3/mgmt:mgmt_scala_proto failed (Exit 1)
```

ScalaPB docs that mention singleLineToString change:
https://scalapb.github.io/sbt-settings.html

Contributor guide

Open the contributing guide

Research direction

Start at scala_proto/scala_proto.bzl around line 484, where the single_line_to_string option is referenced. Build a scalapb_proto_library using the issue’s failing example or equivalent fixture and confirm the unrecognized-parameter error is gone with the ScalaPB 0.7 naming.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.