bazel-contrib / bazel-contrib/rules_scala

Cannot declare a license on scala_import

Open
#353 4 comments 1 reaction 0 assignees View on GitHub
Dominant language
Starlark
Stars
384
Forks
292
Avg merge
2d 22h
Merged PRs (30d)
47

Description

Hello,

I tried the new scala_import rule, and stumbled upon the following error:

```
ERROR: [...]/third_party/java/com/twitter/BUILD:237:1: //third_party/java/com/twitter:finagle_http: no such attribute 'licenses' in 'scala_import' rule
ERROR: [...]/third_party/java/com/twitter/BUILD:237:1: third-party rule '//third_party/java/com/twitter:finagle_http' lacks a license declaration with one of the following types: notice, reciprocal, permissive, restricted, unencumbered, by_exception_only
```

It seems that is not possible either on other Scala rules (unless I am mistaken), and it is indeed required to load third-party Scala rules.

Contributor guide

Open the contributing guide

Research direction

Reproduce the failure from third_party/java/com/twitter/BUILD, focusing on the scala_import target and its license declaration. Inspect the scala_import rule entry point and compare other Scala rules; done means a third-party scala_import target accepts a supported license and passes Bazel's license validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.