bazel-contrib / bazel-contrib/rules_python

bazel run //:gazelle_update_repos modifies gazelle/deps.bzl incorrectly

Open
#2,975 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
688
Forks
721
Avg merge
15h 7m
Merged PRs (30d)
76

Description

`bazel run //:gazelle_update_repos` modifies `gazelle/deps.bzl` incorrectly:

```diff
diff --git a/gazelle/deps.bzl b/gazelle/deps.bzl
index a6789ea3..98fda041 100644
--- a/gazelle/deps.bzl
+++ b/gazelle/deps.bzl
@@ -14,7 +14,11 @@

"This file managed by `bazel run //:gazelle_update_repos`"

-load("@bazel_gazelle//:deps.bzl", _go_repository = "go_repository")
+load(
+ "@bazel_gazelle//:deps.bzl",
+ "go_repository",
+ _go_repository = "go_repository",
+)
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

def go_repository(name, **kwargs):
```

Resulting in an error:

```
ERROR: /usr/local/google/home/dthor/dev/rules_python/gazelle/deps.bzl:24:5: conflicting global declaration of 'go_repository'
ERROR: /usr/local/google/home/dthor/dev/rules_python/gazelle/deps.bzl:19:6: 'go_repository' previously declared as file-local here
ERROR: Analysis of target '//python:stdlib_list' failed; build aborted: Error loading '//python:extensions.bzl' for module extensions, requested by /usr/local/google/home/dthor/dev/rules_python/gazelle/MODULE.bazel:32:35: at /usr/local/google/home/dthor/dev/rules_python/gazelle/python/extensions.bzl:3:6: at /usr/local/google/home/dthor/dev/rules_python/gazelle/python/private/extensions.bzl:4:6: compilation of module 'deps.bzl' failed: at /usr/local/google/home/dthor/dev/rules_python/gazelle/python/extensions.bzl:3:6: at /usr/local/google/home/dthor/dev/rules_python/gazelle/python/private/extensions.bzl:4:6: compilation of module 'deps.bzl' failed
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.