bazel-contrib / bazel-contrib/rules_mypy
RFC: use validation actions
- Dominant language
- Starlark
- Stars
- 12
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
Currently the install instructions say to add
> --output_groups=+mypy
I used to have this requirement in rules_lint too, but changed to use validation actions instead:
https://github.com/aspect-build/rules_lint/pull/562
This is nicer IMO because:
1. registering the `--aspect` is sufficient to ask for the type-checker to run
2. users can still opt-out with Bazel flag `--norun_validations`
3. Removes a potential install mistake where the aspect is registered but its outputs weren't requested
Contributor guide
Research direction
Start by locating the install instructions that currently require `--output_groups=+mypy` and the Bazel aspect registration described in the issue. Compare the validation-action approach in rules_lint PR 562, then verify that registering `--aspect` runs the type checker without the output-group flag and that `--norun_validations` opts out.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100