bazel-contrib / bazel-contrib/rules_jvm_external

`is_repin_required() missing [...] repository_ctx` as of 687dc35

Open
#981 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
373
Forks
301
Avg merge
7d 17h
Merged PRs (30d)
3

Description

I just gave a try with current master branch (as of commit 687dc3578c1b315e8484a095ff6d4a83e696b21d) and faced:
```sh
$ REPIN=1 bazel run @unpinned_maven//:pin
INFO: Repository maven instantiated at:
/path/to/WORKSPACE:138:11: in
/path/to/maven/init.bzl:19:18: in init
/path/to/external/rules_jvm_external/private/rules/maven_install.bzl:136:30: in maven_install
Repository rule pinned_coursier_fetch defined at:
/path/to/external/rules_jvm_external/coursier.bzl:1236:40: in
ERROR: An error occurred during the fetch of repository 'maven':
Traceback (most recent call last):
File "/path/to/external/rules_jvm_external/coursier.bzl", line 465, column 39, in _pinned_coursier_fetch_impl
if _fail_if_repin_required(repository_ctx):
File "/path/to/external/rules_jvm_external/coursier.bzl", line 371, column 29, in _fail_if_repin_required
return is_repin_required()
File "/path/to/external/rules_jvm_external/coursier.bzl", line 363, column 5, in is_repin_required
def is_repin_required(repository_ctx):
Error: is_repin_required() missing 1 required positional argument: repository_ctx
ERROR: /path/to/WORKSPACE:138:11: fetching pinned_coursier_fetch rule //external:maven: Traceback (most recent call last):
File "/path/to/external/rules_jvm_external/coursier.bzl", line 465, column 39, in _pinned_coursier_fetch_impl
if _fail_if_repin_required(repository_ctx):
File "/path/to/external/rules_jvm_external/coursier.bzl", line 371, column 29, in _fail_if_repin_required
return is_repin_required()
File "/path/to/external/rules_jvm_external/coursier.bzl", line 363, column 5, in is_repin_required
def is_repin_required(repository_ctx):
Error: is_repin_required() missing 1 required positional argument: repository_ctx
ERROR: Error computing the main repository mapping: no such package '@maven//': is_repin_required() missing 1 required positional argument: repository_ctx
```
I didn't check what changed yet, but wanted to share this issue prior to next release.

Contributor guide

Open the contributing guide

Research direction

Start in coursier.bzl around _pinned_coursier_fetch_impl, _fail_if_repin_required, and is_repin_required, using the reported REPIN=1 bazel run @unpinned_maven//:pin command to reproduce the failure. Done means the pin command completes without the missing repository_ctx argument error.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.