bazel-contrib / bazel-contrib/rules_go
TOOLS_NOGO is not up to date
- Dominant language
- Go
- Stars
- 1.5k
- Forks
- 760
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 12
Description
### What version of rules_go are you using?
Latest
### What version of gazelle are you using?
Latest
### What version of Bazel are you using?
Latest
### Does this issue reproduce with the latest releases of all the above?
Yes.
### What operating system and processor architecture are you using?
N/A
### Any other potentially useful information about your toolchain?
N/A
### What did you do?
The [`TOOLS_NOGO`](https://github.com/bazelbuild/rules_go/blob/8a362829c17b92266f5e1e79cdc1cfc38ec3f86a/go/def.bzl#L78-L81) variable claims to be `...a list of all analysis passes in https://pkg.go.dev/golang.org/x/tools/go/analysis/passes`.
### What did you expect to see?
There are analysers missing.
### What did you see instead?
I haven't checked all of them, but [reflectvaluecompare](https://pkg.go.dev/golang.org/x/tools@v0.1.10/go/analysis/passes/reflectvaluecompare) is missing, for instance.
Contributor guide
Research direction
Start in go/def.bzl at the TOOLS_NOGO definition and compare its entries with the analysis passes listed at pkg.go.dev/golang.org/x/tools/go/analysis/passes. Check the reported reflectvaluecompare omission and identify other missing analyzers. Done means the variable is up to date with the referenced pass list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100