bazel-contrib / bazel-contrib/rules_go

go/tools/releaser upgrade-dep - remove dependency on local time zone

Open
#2,973 0 comments 0 reactions 1 assignee Claimed by @robfig View on GitHub
Dominant language
Go
Stars
1.5k
Forks
760
Avg merge
1d 11h
Merged PRs (30d)
12

Description

Updating dependencies resulted in unexpected diffs due to an implicit dependency on the local machine's time zone.

After running:
```
$ bazel run //go/tools/releaser -- upgrade-dep -mirror=false all
```

I saw a number of files modified like so:
```
---- a/conformance/internal/conformance_proto/BUILD.bazel 1969-12-31 16:00:00.000000000 -0800
+--- a/conformance/internal/conformance_proto/BUILD.bazel 1969-12-31 19:00:00.000000000 -0500
```

The timestamp is already set explicitly, and ideally the time zone would be too.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.