bazel-contrib / bazel-contrib/rules_go

go: deprecate the go_rule wrapper

Open
#2,302 2 comments 0 reactions 0 assignees View on GitHub
code-health go
Dominant language
Go
Stars
1.5k
Forks
760
Avg merge
1d 11h
Merged PRs (30d)
12

Description

See bazelbuild/bazel-gazelle#676.

A Bazel incompatibility flag (possibly `--incompatible_remap_main_repo`, see bazelbuild/bazel#7130) causes default labels in attributes to be resolved in `@io_bazel_rules_go//go/private` (where `go_rule` is defined) instead of wherever the rule should actually have been defined.

We use `go_rule` as a wrapper around `rule` to add hidden attributes and a toolchain dependency. Instead, we should move hidden attributes to the toolchain *or* provide a set of common attributes. The toolchain dependency can be explicit.

Contributor guide

Open the contributing guide

Research direction

Start by reading the go_rule wrapper in the go/private area and the linked bazel-gazelle#676 and bazel#7130 discussions. Determine whether hidden attributes should move to the toolchain or become common attributes, and make the toolchain dependency explicit. Done means the wrapper is deprecated or removed without the affected default-label incompatibility.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.