bazel-contrib / bazel-contrib/rules_foreign_cc

Failing postfix_script should fail the build

Open
#954 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Starlark
Stars
737
Forks
270
PR merge metrics
No merged PRs in 30d

Description

When specifying
```
postfix_script = "false",
```
in a `cmake` rule, I'd expect this to fail the build. Actually, this silently succeeds.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue with a CMake rule containing postfix_script = "false" and observe the build result. Trace how postfix_script is handled and check related tests; done means the build fails when that command returns false.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.