bazel-contrib / bazel-contrib/rules_foreign_cc

ctx.attr.tools_deps and ctx.attr.additional_tools is redundant - rename to a single ctx.attr.tools?

Open
#490 10 comments 3 reactions 1 assignee Claimed by @jsharpe View on GitHub
Dominant language
Starlark
Stars
737
Forks
270
PR merge metrics
No merged PRs in 30d

Description

There is no real distinction between `ctx.attr.tools_deps` and `ctx.attr.additional_tools`. Most other rules canonically use `ctx.attr.tools` so I am proposing that we should deprecate the former two and move to the latter for tools used within the build.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.