bazel-contrib / bazel-contrib/rules_foreign_cc

legacy dependency macro fails to set up transitive dependencies

Open
#1,286 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
737
Forks
270
PR merge metrics
No merged PRs in 30d

Description

```
ERROR: Skipping '@symengine': error loading package '@@symengine//': at /private/var/tmp/_bazel_oliver/e888b1acfe919fa909be3f7123974edb/external/rules_foreign_cc/foreign_cc/defs.bzl:3:6: at /private/var/tmp/_bazel_oliver/e888b1acfe919fa909be3f7123974edb/external/rules_foreign_cc/foreign_cc/boost_build.bzl:5:5: at /private/var/tmp/_bazel_oliver/e888b1acfe919fa909be3f7123974edb/external/rules_foreign_cc/foreign_cc/private/framework.bzl:5:6: at /private/var/tmp/_bazel_oliver/e888b1acfe919fa909be3f7123974edb/external/bazel_features/features.bzl:3:6: Unable to find package for @@bazel_features_globals//:globals.bzl: The repository '@@bazel_features_globals' could not be resolved: Repository '@@bazel_features_globals' is not defined.
```

`bazel_features` is pulled in here:
https://github.com/bazelbuild/rules_foreign_cc/blob/b25485b26d6ddf6be8bde2bc0c651b1a06ebe54c/foreign_cc/repositories.bzl#L86-L92

But I don't see (a second macro for) `bazel_features_deps`:
https://github.com/bazel-contrib/bazel_features/blob/main/deps.bzl
which in turn sets up these:
https://github.com/bazel-contrib/bazel_features/blob/main/private/repos.bzl

Contributor guide

Open the contributing guide

Research direction

Start in foreign_cc/repositories.bzl, where bazel_features is pulled in, and compare that setup with bazel_features' deps.bzl and private/repos.bzl. Reproduce the missing @@bazel_features_globals error, then verify that the legacy dependency macro initializes the required transitive repositories.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.