bazel-contrib / bazel-contrib/rules_foreign_cc

environment variables passed to makefile should take care about space on windows

Open
#1,280 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
737
Forks
270
PR merge metrics
No merged PRs in 30d

Description

I used configure_make to build openssl on windows use msvc, for rules_foreign_cc pass cc's path with space, this caused
```
NMAKE : fatal error U1077: The system cannot find the path specified
```
can guys fix this problem?

Contributor guide

Open the contributing guide

Research direction

Start with the configure_make rules and the Makefile environment-variable handling, reproducing the MSVC Windows build with a compiler path containing spaces. Done means the build no longer produces NMAKE U1077 for that path and still works for paths without spaces.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.