bazel-contrib / bazel-contrib/rules_foreign_cc

Why does the lib_source need to be labels?

Open
#1,122 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
737
Forks
270
PR merge metrics
No merged PRs in 30d

Description

Very often the external lib repo does not have a :srcs target to be used here:
https://github.com/bazelbuild/rules_foreign_cc/blob/0258d350a9ff4c5145f131b7247d161a432dec8d/examples/make_simple/BUILD.bazel#L17

For example, https://github.com/pciutils/pciutils has no BUILD setup. If I can add a BUILD setup there, I wouldn't need to use these external targets, right?

So, how can I externally build that repo lib, and use it as a dependency label in my bazel flow? It's only a make call, but I need this tool to sort out the cached repo path.

Contributor guide

Open the contributing guide

Research direction

Start with the linked examples/make_simple/BUILD.bazel line and inspect how lib_source is expected to be supplied. Compare that flow with the pciutils repository, which has no BUILD setup, and review the existing external Make integration. Done means establishing a defined approach for building such a repository externally and consuming its result as a dependency label.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.