bazel-contrib / bazel-contrib/rules_foreign_cc

CPPFLAGS is empty with configure_make

Open
#1,026 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
737
Forks
270
PR merge metrics
No merged PRs in 30d

Description

Hi,

I'm using `configure_make` with Bazel. My toolchain currently uses the `sysroot_feature`, which passes the flag `--sysroot` to the compiler. This feature is active for `all_compile_actions`, including `ACTION_NAMES.preprocess_assemble`.

It seems however these flags are not passed on by `configure_make` to `CPPFLAGS`. In fact, I find that `CPPFLAGS` is empty, unlike `CFLAGS` and `CXXFLAGS`! Is that expected?

Contributor guide

Open the contributing guide

Research direction

Start with the configure_make handling of compiler flags and compare how CFLAGS and CXXFLAGS are populated with CPPFLAGS. Determine whether the sysroot flag from the sysroot_feature is expected to appear in CPPFLAGS, and document or test the observed behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, cpp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.