bazel-contrib / bazel-contrib/rules_bazel_integration_test

Support workspace files with spaces in their names

Open
#62 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Starlark
Stars
65
Forks
16
Avg merge
1d 9h
Merged PRs (30d)
9

Description

Currently, the rules rely on passing workspace files to the child workspace using `runfiles`. However, a [known Bazel issue](https://github.com/bazelbuild/bazel/issues/4327) prevents files with spaces in their names from working properly. Ideally, this will be fixed in Bazel. However, for now, we may want to allow a client to specify whether to use an alternative mechanism.

Possible solutions:

1. Add the files to an archive file and pass that through runfiles
2. Create a mechanism that creates symlinks from a more robust file format as compared to the current, space-delimited format.

Contributor guide

Open the contributing guide

Research direction

No file or test is named. Start by locating the rule or macro that passes workspace files to the child workspace through runfiles, then reproduce the failure with a filename containing spaces. Compare the archive and symlink alternatives described in the issue; done means workspace files with spaces work through a documented, selectable mechanism.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.