bazel-contrib / bazel-contrib/platforms_contrib

Add fpu constraints

Open Beginner friendly
#4 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Starlark
Stars
7
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Older ARM cores can be configured without an FPU or without NEON, which causes general-purpose code to run much slower so LLVM assumes that these are always available. For most silicon out there this is true, but there are exceptions, some of which we care about so this constraint can select these non-standard core configs. This proposes the following addition:

```starlark
# //fpu/BUILD.bazel

constraint_setting(
name = "fpu",
default_constraint_value = ":neon",
)

constraint_value(
name = "neon",
constraint_setting = ":fpu",
)

constraint_value(
name = "vfpv4-d16",
constraint_setting = ":fpu",
)
```

Contributor guide

Open the contributing guide

Research direction

Start with //fpu/BUILD.bazel, the file named in the issue. Add the proposed fpu constraint setting and its neon and vfpv4-d16 values, then verify that the BUILD file is accepted by the repository's Bazel checks. Done means the constraint can select these non-standard ARM core configurations.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.