bazel-contrib / bazel-contrib/bazel-lib

[FR]: Allow diff_test to specify diff toolchain

Open
#529 8 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Starlark
Stars
182
Forks
134
Avg merge
1d 46m
Merged PRs (30d)
1

Description

### What is the current behavior?

Currently, rules like `diff_test` (and rules that use it, including `write_source_files`) expect `diff` to be in the PATH.
This fails on NixOS (and platforms where diff is not preinstalled).

### Describe the feature

Provide a method to specify the diff binary (via toolchain or label).

Contributor guide

Open the contributing guide

Research direction

Start with the diff_test and write_source_files entry points, tracing how they currently resolve diff from PATH. Determine how a toolchain or label could select the binary, and consider the NixOS case; the work is done when callers can provide a diff binary without requiring diff to be preinstalled.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.