bazel-contrib / bazel-contrib/bazel-lib

write_source_file's tests should check the executable bit

Open
#1,089 0 comments 1 reaction 0 assignees View on GitHub
good first issue help wanted
Dominant language
Starlark
Stars
182
Forks
134
Avg merge
1d 46m
Merged PRs (30d)
1

Description

Whether the output file is executable is part of write_source_file's declared state, so it should be checked in tests along with diffing the contents. Currently, you can run the updater, manually flip the executable bit on the output, and the tests will still pass.

Contributor guide

Open the contributing guide

Research direction

Search for write_source_file and its existing tests, then run the relevant test to establish the current behavior. Update the test coverage so it checks both the generated contents and whether the output file has the declared executable bit; done means a manually changed executable bit no longer passes unnoticed.

Written by the indexing model from the issue text.

Assessment

Domain
build-system, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.