bazel-contrib / bazel-contrib/bazel-lib

diff_test should first run an action that produces a diff output, so it's easy to "accept" the patch

Open
#1,067 1 comment 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Starlark
Stars
182
Forks
134
Avg merge
1d 46m
Merged PRs (30d)
1

Description

Currently our diff_test (as well as the one in rules_diff) runs `diff` to produce a patch as an ephemeral command during a test action. This means that tooling can't find the resulting patch file and offer to apply it.

Contributor guide

Open the contributing guide

Research direction

Start by locating the diff_test and rules_diff implementations mentioned in the issue, then inspect how their test actions invoke diff and where action outputs are declared. Done means the diff-producing action leaves a patch file that tooling can discover and offer to apply, rather than producing it only as an ephemeral command result.

Written by the indexing model from the issue text.

Assessment

Domain
build-system, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.