bazel-contrib / bazel-contrib/bazel-lib

diff_test does not escape the error message string and allows for shell injection

Open
#1,064 1 comment 0 reactions 0 assignees View on GitHub
bug help wanted
Dominant language
Starlark
Stars
182
Forks
134
Avg merge
1d 46m
Merged PRs (30d)
1

Description

Strings in `failure_message` are interpolated into the generated shell script without escaping special characters:
```
diff_test(
name ="foo",
file1 = ":a.txt",
file2 = ":b.txt",
failure_message = "shell injection: `echo hello world`",
)
```

Actual test output:

```
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //:foo
-----------------------------------------------------------------------------
1d0
< 1
FAIL: files "a.txt" and "b.txt" differ. shell injection: hello world
```

expected:
```
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //:foo
-----------------------------------------------------------------------------
1d0
< 1
FAIL: files "a.txt" and "b.txt" differ. shell injection: `echo hello world`
```

Same issue with using `failure_message = "$(echo hello world)"`

Contributor guide

Open the contributing guide

Research direction

Locate the diff_test implementation and reproduce the issue with the provided failure_message values using backticks and $(...). Trace how the generated shell script incorporates failure_message, then verify that both forms remain literal in the failure output and do not execute commands.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
build-system, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.