basecamp / basecamp/trix

Support darkmode - button icons should turn white

Open
#947 6 comments 13 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
20k
Forks
1.1k
Avg merge
3d 12h
Merged PRs (30d)
13

Description

Describe the bug or issue here…

While following the [rails 7 ](https://www.youtube.com/watch?v=mpWFrUwAN88&t=673s)screencast by dhh, realized trix does not support dark mode yet

##### Steps to Reproduce

1. Enable dark mode at MacOS system level
2. Use simplecss.org cdn at application.html.erb
3. Trix buttons icon did not switch to white color to support dark mode. See below

![CleanShot 2021-12-24 at 10 14 03](https://user-images.githubusercontent.com/323891/147307445-38ac4729-3a53-4364-9cc4-7745c67505d1.png)

##### Details

* Trix version: 1.3.1
* Browser name and version: Safari 15 (16612.1.29.41.4, 16612)
* Operating system: MacOS 11.6 (20G165)

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue in application.html.erb using the simplecss.org stylesheet, with dark mode enabled on macOS Safari. Start by tracing the Trix button icon styling and verify that the icons render white in dark mode; done means the toolbar icons remain visible against the dark theme.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
design, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.