basecamp / basecamp/trix

Un-indenting list item doesn't properly un-indent children

Open
#907 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
20k
Forks
1.1k
Avg merge
3d 12h
Merged PRs (30d)
13

Description

Un-indenting a parent item of a bulleted or numbered list doesn't properly un-indent children. The same issue occurs when selecting all list items and attempting to un-indent.

##### Steps to Reproduce

1. Create a bulleted or numbered list with two items.
2. Indent the second item.
3. Un-indent the first item. (Or select both items and attempt to un-indent)

Here's a video demonstrating the issue:

https://user-images.githubusercontent.com/11605395/120840062-94bc6f00-c51e-11eb-8100-0aab68cc86d1.mov

Here's the HTML before and after attempting to un-indent:

**Before**
```




  • Item 1



    • Item 2




```

**After (Result)**
```



Item 1






    • Item 2




```

**Expected result**
```



Item 1




  • Item 2


```
This is what _should_ happen:
Screen Shot 2021-06-04 at 10 31 19 AM

##### Details

* Trix version: 1.3.1
* Browser name and version: Chrome 91, Safari
* Operating system: macOS, Android, iOS

(This issue doesn't appear to be platform-specific)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.