basecamp / basecamp/trix

Bold and italic text does not work properly on Android

Open
#893 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
20k
Forks
1.1k
Avg merge
3d 12h
Merged PRs (30d)
13

Description

##### Details

* Trix version: 1.3.1 (from Yarn)
* Browser name and version: Chrome and Firefox, see below
* Operating system: Android 10

The bold and italic functions do not work correctly on Android. Chrome and Firefox have different issues.

On Chrome (89.0.4389.86), pressing bold/italic depresses the action button. Correct so far, but when writing text it is not bold/italic. It will only turn bold/italic after pressing space, or rather, it will keep the previous style until space is pressed. I'm attaching a video of the bug.

https://user-images.githubusercontent.com/12595797/111477382-b8e68c00-8737-11eb-95e3-a311ca64b677.mp4

On Firefox (86.1.1), the bold/italic indicators do not work correctly. Pressing the button depresses it, but after writing, it ends up toggling between unpressed/depressed. Unlike on Chrome, the text itself will be correctly bold or italic. I'm attaching a video of this as well.

https://user-images.githubusercontent.com/12595797/111476496-e2eb7e80-8736-11eb-8b5c-03fd5a20f506.mp4

I don't see this issue on the desktop version of either browser.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.