basecamp / basecamp/trix

Pasting an image from the clipboard on iOS can insert multiple images

Open
#719 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
20k
Forks
1.1k
Avg merge
3d 12h
Merged PRs (30d)
13

Description

When pasting an image from the clipboard on iOS 13 that has multiple representations, it can insert all representations instead of just a single image. It may affect earlier versions of iOS, but I haven't seen it until iOS 13.

##### Steps to Reproduce

Here are two methods:

1. Go to trix-editor.org in mobile Safari on iOS 13
2. Focus the field and insert a Memoji from the keyboard
3. It will insert a JPG and PNG

OR...

1. Go to trix-editor.org in mobile Safari on iOS 13
2. Take a screenshot and tap the floating thumbnail
3. From the screenshot markup screen, tap the share button and choose "Copy".
4. You'll now have a JPG and PNG on the clipboard.
5. Focus the editor and choose "Paste"
6. It will insert both the JPG and PNG

Screen Shot 2020-01-03 at 5 35 35 PM

Here's an input inspector profile of pasting the screenshot: https://input-inspector.now.sh/profiles/F4Rcp0EGKqE6OJcDFL1L

##### Details

* Trix version: 1.2.2
* Browser name and version: Safari
* Operating system: iOS 13.3

Contributor guide

No contributing guide indexed for this repository

Research direction

No source file or test is named. First reproduce the behavior at trix-editor.org in mobile Safari on iOS 13 using the Memoji or screenshot-copy steps, then trace the editor's paste handling; done means a clipboard containing multiple image representations inserts only one image.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, javascript
Domain
frontend, mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.