basecamp / basecamp/trix

Custom toolbars can't be placed below the editor

Open
#592 2 comments 2 reactions 0 assignees View on GitHub
bug confirmed
Dominant language
JavaScript
Stars
20k
Forks
1.1k
Avg merge
3d 12h
Merged PRs (30d)
13

Description

Placing the toolbar below the editor results in errors:

```
Uncaught TypeError: Cannot read property 'querySelectorAll' of null
at s.resetDialogInputs (trix.js:17)
at new s (trix.js:17)
at new a (trix.js:20)
at HTMLElement.connect (trix.js:21)
at HTMLElement.n (trix.js:15)
```

##### Steps to Reproduce

```



```

##### Details

* Trix version: 1.0.0
* Browser name and version: Chrome 71
* Operating system: Mac OS 10.14

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the toolbar connection path shown in the trix.js stack trace, especially resetDialogInputs and HTMLElement.connect. Reproduce the issue using the supplied markup with the trix-editor before the trix-toolbar, then verify that the editor initializes without the querySelectorAll error when the toolbar is below it.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.