basecamp / basecamp/trix

enableObjectResizing no longer needed in Firefox

Open
#1,101 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
20k
Forks
1.1k
Avg merge
3d 12h
Merged PRs (30d)
13

Description

Hey,
Firefox stopped requiring disabling controls five years ago [1]. So you are now able to remove one of your two last usages of `document.execCommand`. You may also want to remove the very last one.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1490641

Contributor guide

No contributing guide indexed for this repository

Research direction

Search the repository for `enableObjectResizing` and both remaining uses of `document.execCommand`; read the surrounding editor code and any relevant tests. Confirm the Firefox behavior described in the linked Bugzilla report, then verify that the obsolete usage is removed without breaking the editor or its tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.