basecamp / basecamp/thruster

Wrong redirect location when HTTPS_PORT is set

Open
#100 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.2k
Forks
58
Avg merge
1d 2h
Merged PRs (30d)
6

Description

If `HTTPS_PORT` is different from 443, the redirect location is wrong - it should append the `config.HttpsPort` here if it's not 443: https://github.com/basecamp/thruster/blob/main/internal/server.go#L148-L153

Contributor guide

Open the contributing guide

Research direction

Start at internal/server.go lines 148-153 and inspect how the HTTPS redirect location is assembled when HTTPS_PORT differs from 443. Verify the resulting location includes the configured port for non-default HTTPS ports while preserving the existing behavior for port 443.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.