basecamp / basecamp/marginalia
Warning: loading in progress, circular require considered harmful
- Dominant language
- Ruby
- Stars
- 1.8k
- Forks
- 148
- PR merge metrics
- No merged PRs in 30d
Description
Hello.
I get the following warning after upgrading ruby from 3.1.2 to 3.3.6
```warning: loading in progress, circular require considered harmful - .../.rbenv/versions/3.3.6/gemsets/.../gems/marginalia-1.11.1/lib/marginalia.rb```
Looks like the following [line](https://github.com/basecamp/marginalia/blob/master/lib/marginalia/railtie.rb#L1) of code needs to be removed.
Rails version - 7.0.8.7
Ruby version - 3.3.6
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by inspecting lib/marginalia/railtie.rb at the linked first line and reproduce the warning with Ruby 3.3.6 and Rails 7.0.8.7. Confirm that the circular-require warning is no longer emitted while Marginalia still attaches comments to ActiveRecord SQL queries.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails, ruby
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100