base / base/withdrawer

fix: set --fault proofs CLI default to true for built in fault-proof networks

Open
#87 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
537
Forks
373
PR merge metrics
No merged PRs in 30d

Description

All four built-in networks (base-mainnet, base-sepolia, op-mainnet, op-sepolia) have `faultProofs: true` and their `l2oo-address` set to `0x0`. However, the `--fault-proofs` CLI flag defaults to `false`.

A user running a simple command like:

withdrawer --network base-mainnet --withdrawal --rpc --private-key

...gets a crash with: "Fault proofs are required on this network, please provide the --fault-proofs flag".

Since all built-in networks use fault proofs, the default should be `true` to match the network configurations.

**Fix:**
Change the default from `false` to `true` in main.go:
go
flag.BoolVar(&faultProofs, "fault-proofs", true, "Use fault proofs")

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.