base / base/account-sdk

Bug: README code examples missing await on provider.request() calls

Open Beginner friendly
#272 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
172
Forks
207
Avg merge
49m
Merged PRs (30d)
1

Description

### Describe the bug

Two code examples in the README are missing `await` on `provider.request()` calls, which would cause unexpected behavior for anyone copying the examples.

### Steps

1. See README.md lines 176 and 184
2. const addresses = provider.request({ method: 'eth_requestAccounts' });
3. provider.request('personal_sign', [...]);

### Expected behavior

Both calls should have await since provider.request() returns a Promise:

const addresses = await provider.request({ method: 'eth_requestAccounts' });
await provider.request('personal_sign', [...]);

### Version

latest

### Additional info

_No response_

### Desktop

_No response_

### Smartphone

_No response_

Contributor guide

Open the contributing guide

Research direction

Open README.md at lines 176 and 184 and review the two provider.request() examples. Add await to both calls, then verify the examples show the expected Promise-handling behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.