basarat / basarat/typescript-amd

Require.d.ts Uses Bool, should use boolean

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
17
Forks
7
PR merge metrics
No merged PRs in 30d

Description

```
// If set to true, an error will be thrown if a script loads
// that does not call define() or have shim exports string
// value that can be checked.
enforceDefine?: bool;

// If set to true, document.createElementNS() will be used
// to create script elements.
xhtml?: bool;
```

Should be:

```
// If set to true, an error will be thrown if a script loads
// that does not call define() or have shim exports string
// value that can be checked.
enforceDefine?: boolean;

// If set to true, document.createElementNS() will be used
// to create script elements.
xhtml?: boolean;
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.