bannzai / bannzai/SpreadsheetView

Present a popover on tapped cell

Open
#167 1 comment 0 reactions 1 assignee Claimed by @kishikawakatsumi View on GitHub
help wanted
Dominant language
HTML
Stars
3.5k
Forks
476
PR merge metrics
No merged PRs in 30d

Description

## Expected Behavior

## Actual Behavior

While presenting a popover over a cell that was tapped on, doing this should give the rect of the tapped cell -
```
let rect = self.gradebookView.rectForItem(at: indexPath)
let rectInView = self.gradebookView.convert(rect, to: self.view)
```
but it seems the rect being obtained after converting it to the parent view's coordinate is not right and the popover always ends up getting opened someplace else and sometimes even out of the view.

## Steps to Reproduce the Problem

1. Tap on a cell
2. Get the rect of the cell in didSelectItemAt:indexPath and convert that rect to the parent view's coordinates
3. Presenting the popover with that sourceRect shows the popover over a completely different cell.

## Specifications

- Xcode version: 9.1
- iOS version: 11.1
- Dependency manager + version: 0.8.4

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.