bamlab / bamlab/react-native-image-header-scroll-view

Typing ImageHeaderScrollView && TriggeringView

Open
#97 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1k
Forks
101
PR merge metrics
No merged PRs in 30d

Description

Hi, we have some problems with the ImageHeaderScrollView, a lot of props are necessary and some types are strange.

For example, when we updated our version of your plugin we got errors because of those types

renderFixedForeground: () => React.ElementType;
renderForeground?: () => React.ElementType;

Why it's not :

renderFixedForeground: () => React.Element;
renderForeground?: () => React.Element;

Like I mentioned, a lot of props are necessary but they are not useful for a basic utilisation :

image

We tried to copy/past your example (in the official doc) and we got a lot of errors,

In our case, we overloaded the index file and we fixed it with our on patch and finally it worked but we want to know if it's a mistake or if we miss something ?

Thank you in advance

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.