bamlab / bamlab/generator-rn-toolbox

Commits with quotations fail

Open
#243 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.2k
Forks
116
PR merge metrics
No merged PRs in 30d

Description

Example

> FastlaneCore::Interface::FastlaneShellError: [!] Exit status of command 'cd .. && appcenter codepush release-react -d Staging -a username/app--target-binary-version "1.0.0" --description "Revert "Test soft deployment"" --disable-duplicate-release-error' was 3 instead of 0.

This is due to the following auto generated line of code in the Fastfile:

```ruby
release_notes_command = "git log HEAD --pretty=format:\"%s\" -1"
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the generated Fastfile and inspect how release_notes_command builds the git log command. Reproduce the reported release with a commit message containing quotations, then verify that the generated command handles those quotations and the release no longer exits with status 3.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, react-native, ruby
Domain
mobile, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.