bamlab / bamlab/generator-rn-toolbox
yarn flow failing on the Page component
Open
- Dominant language
- JavaScript
- Stars
- 1.2k
- Forks
- 116
- PR merge metrics
- No merged PRs in 30d
Description
I've got an issue while running flow on a base generated project.
Indeed, `noNavBar` and `noMargin` props of the `Page` component are typed as required, but I don't think they should be.
If you agreed, I can do a Pull Request !
Contributor guide
No contributing guide indexed for this repository
Research direction
Locate the Page component in the base generated project and inspect the Flow types for the noNavBar and noMargin props. Run yarn flow to reproduce the failure. Done means those props are no longer required and Flow passes for the generated project.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100