bamlab / bamlab/commentor

[Feature Request] Don't mixup code review comments with discussion comments

Open
#163 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
45
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Hello,

Pull-request is not only a place to make code review feedbacks. Sometimes it generates discussions, questions, and some developers also like to celebrate and share some love. 😁

The issue is all these comments unrelated to code review are displayed on the dashboard making it hard to read.

I'm not your UX but here are my 2 cents: it might be cool to use a markdownish syntax specific to Commentor in order to tags comments (_e.g._, "You should make an early return here. {tag: clean-code}"), and filter these tagged comments in the dashboard table.

I'd be happy to discuss about it!

EDIT: I could also use the filter feature. 😬 But what is the purpose to display non-tagged comments in the dashboard so? 🤔

EDIT2: with a special syntax we could dynamically generate tags from the comments (might not be a good idea tho)

Contributor guide

Open the contributing guide

Research direction

The issue does not name any files, tests, or entry points. First clarify whether the goal is comment tagging, dashboard filtering, or both, then inspect the dashboard comment display and existing filter behavior. Done should be defined as a clear, agreed way to separate code-review comments from discussion comments without hiding expected dashboard data.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
analytics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.