bamlab / bamlab/commentor

Allow Gitlab user to use on premise instances of gitlab as oAuth provider

Open
#145 0 comments 0 reactions 1 assignee Claimed by @sraikimaxime View on GitHub
enhancement good first issue
Dominant language
TypeScript
Stars
45
Forks
1
PR merge metrics
No merged PRs in 30d

Description

**Why ?**
In order to let you access a project on Commentor, we check with your oAuth provider if you still have access to this project. Then this means that you wont be able to use Commentor today with an auto hosted instance of Gitlab as we will check if you have access to it through gitlab.com who doesn't know this.

**What ?**
Whenever a user hits the connect with gitlab button
![image](https://user-images.githubusercontent.com/15715425/85208319-a0c01880-b32f-11ea-96b6-4402f08f3a8f.png)

We should present him a modal with a "Gitlab.com" Button and an input with a placeholder saying "Specify your on premise gitlab instance" and a button trigering the connexion to this instance.

This means we should also store in the cookies the gitlab instance this user wants to be connected to and use it instead of gitlab.com on the calls from the Gitlab oAuth provider
![image](https://user-images.githubusercontent.com/15715425/85208356-f85e8400-b32f-11ea-802e-55de3dd8e971.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.