balderdashy / balderdashy/sails

Remove socket error logs during automatic disconnect/reconnect of Redis/Sails app

Open
#7,296 1 comment 0 reactions 0 assignees View on GitHub
what do you think?
Dominant language
JavaScript
Stars
22.8k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

## Problem
Currently there will be `sails-hook-sockets` error logs when Redis and Sails disconnect and reconnect automatically. Something like this 👇🏾

![image (1)](https://github.com/balderdashy/sails/assets/24433274/7bfc7f31-dc37-4d7c-8d1f-95b54c744332)

## Solution
Log as verbose and not error when the disconnect/reconnect happens and it's not an error but the more opportunistic automatic disconnect/reconnect

Contributor guide

Open the contributing guide

Research direction

Start by tracing the sails-hook-sockets logging path for Redis and Sails automatic disconnect/reconnect events. Confirm how the current messages are emitted and identify existing coverage, if any. Done means these expected lifecycle events are logged at verbose level rather than error, without changing genuine socket errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, redis
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.