balderdashy / balderdashy/sails

Sails client never connects if client opens when server is down (and then online).

Open
#6,798 21 comments 0 reactions 0 assignees View on GitHub
resolved sockets
Dominant language
JavaScript
Stars
22.8k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

**Node version**: 10.9
**Sails version** _(sails)_:1.2.2
**ORM hook version** _(sails-hook-orm)_: irrelevant
**Sockets hook version** _(sails-hook-sockets)_: unknown
**Organics hook version** _(sails-hook-organics)_: unknown
**Grunt hook version** _(sails-hook-grunt)_: unused
**Uploads hook version** _(sails-hook-uploads)_: unknown
**DB adapter & version** _(e.g. sails-mysql@5.55.5)_: irrelevant
**Skipper adapter & version** _(e.g. skipper-s3@5.55.5)_: unknown


The title pretty much says it all.
If I open my web app when the server is down, and then turn the server on, sails client will never succeed to connect.

Meaning that `io.socket.on('connect'...` will never trigger.

Any idea why? Sounds like a bug to fix.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the connection sequence with Node 10.9 and Sails 1.2.2: open the client while the server is down, then bring the server online and observe whether io.socket.on('connect'...) fires. Trace the client connection and retry behavior, and add a regression test showing that the client connects after the server returns.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.