balderdashy / balderdashy/sails
sails-mysql username cannot accept special characters
- Dominant language
- JavaScript
- Stars
- 22.8k
- Forks
- 1.9k
- PR merge metrics
- No merged PRs in 30d
Description
Sails version: 1.0.2
Node version: 8.11.2
NPM version: 5.6.0
DB adapter name: sails-mysql
DB adapter version: 1.0.0
Operating system: macOS High Sierra 10.13.5
======================================================
I am deploying the sailsjs code to a production environment where the username has a special character. For example, user@sitename
`mysql://user@site1:myPassWord@localhost:3306/awesomedbname`
If we have "@" for the username, the site1 becomes the host.
Any fix for this?
Contributor guide
Research direction
Start with the sails-mysql connection handling and reproduce the issue using the MySQL URL shown in the report, with @ in the username. Trace how the URL identifies the username and host; done means the complete username is preserved and site1 is not treated as the host.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, mysql, node.js
- Domain
- backend, database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100