balderdashy / balderdashy/sails

Certain special characters in MySQL database password causing problem (sails-mysql adapter)

Open
#4,352 8 comments 0 reactions 0 assignees View on GitHub
bug mysql orm
Dominant language
JavaScript
Stars
22.8k
Forks
1.9k
PR merge metrics
No merged PRs in 30d

Description

**Sails version**: 1.0.0
**Node version**: 8.11.0
**NPM version**: 5.6.0
**DB adapter name**: sails-mysql
**DB adapter version**: 1.0.0.-17
**Operating system**: Debian 9


Passwords starting with an exclamation mark cause the database connection to fail. This was already mentioned in Issue #4204 but the issue is closed without a resolution. In my opinion special characters should work in passwords, no matter if there at the beginning or not.

*Steps to reproduce:*

Use sails-mysql and set up a datastore with a password something like "!!xyz123". Try to lift the app with sails lift

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the failure in a Sails app using the sails-mysql adapter and a datastore password beginning with !, then trace the connection path used by `sails lift`. Done means the app lifts successfully with that password; the issue names no file or test to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, mysql, node.js
Domain
databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.