RpcChannelOptions的connect_timeout是否支持呢
- Dominant language
- C++
- Stars
- 2.1k
- Forks
- 649
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/baidu/sofa-pbrpc/blob/c2cf3522e017260201dc6ea16c68acd025d6102c/src/sofa/pbrpc/rpc_channel.h#L20-L28
你好，我在看代码的时候发现connect_timeout被注释为Not supported now，但是在
https://github.com/baidu/sofa-pbrpc/blob/c2cf3522e017260201dc6ea16c68acd025d6102c/src/sofa/pbrpc/rpc_client_impl.cc#L382
https://github.com/baidu/sofa-pbrpc/blob/c2cf3522e017260201dc6ea16c68acd025d6102c/src/sofa/pbrpc/rpc_byte_stream.h#L110-L115
中，似乎有检查了超时，所以，到底是否支持超时设置呢，单位又是毫秒还是秒呢
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the connect_timeout declaration in src/sofa/pbrpc/rpc_channel.h at lines 20-28, then trace the timeout checks referenced in src/sofa/pbrpc/rpc_client_impl.cc around line 382 and src/sofa/pbrpc/rpc_byte_stream.h at lines 110-115. Determine whether the option is supported and whether its unit is milliseconds or seconds; done means the API behavior and unit are unambiguous.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend-api-design, networking
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100