baidu / baidu/Jprotobuf-rpc-socket

ChannelPoolObjectFactory.wrap方法的实现问题

Open
#49 1 comment 0 reactions 1 assignee Claimed by @jhunters View on GitHub
bug
Dominant language
Java
Stars
535
Forks
216
PR merge metrics
No merged PRs in 30d

Description

ChannelPoolObjectFactory的wrap方法应该是有问题,这里节选了一部分代码如下:

public PooledObject wrap(Connection obj) {
Connection connection = fetchConnection();

// 中间代码省略....

return new DefaultPooledObject(connection);
}

wrap输入参数obj应该是已经调用ChannelPoolObjectFactory.create方法,在create方法里面已经调用fetchConnection, 为什么wrap里面还要再次fetchConnection,导致两次创建Connection.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.