bahmutov / bahmutov/cypress-repeat

crash with no results

Open
#34 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
39
Forks
12
PR merge metrics
No merged PRs in 30d

Description

A failed start due to what looks like https://github.com/cypress-io/cypress/issues/17627 causes cypress-repeat to crash
```
10:59:15 error: Cannot read properties of undefined (reading 'filter')
10:59:15 TypeError: Cannot read properties of undefined (reading 'filter')
10:59:15 at onTestResults (/node_modules/cypress-repeat/index.js:110:14)
10:59:15 at tryCatcher (/node_modules/bluebird/js/release/util.js:16:23)
10:59:15 at Promise._settlePromiseFromHandler (/node_modules/bluebird/js/release/promise.js:547:31)
10:59:15 at Promise._settlePromise (/node_modules/bluebird/js/release/promise.js:604:18)
10:59:15 at Promise._settlePromise0 (/node_modules/bluebird/js/release/promise.js:649:10)
10:59:15 at Promise._settlePromises (/node_modules/bluebird/js/release/promise.js:729:18)
10:59:15 at Promise._fulfill (/node_modules/bluebird/js/release/promise.js:673:18)
10:59:15 at Promise._resolveCallback (/node_modules/bluebird/js/release/promise.js:466:57)
10:59:15 at Promise._settlePromiseFromHandler (/node_modules/bluebird/js/release/promise.js:559:17)
10:59:15 at Promise._settlePromise (/node_modules/bluebird/js/release/promise.js:604:18)
10:59:15 at Promise._settlePromise0 (/node_modules/bluebird/js/release/promise.js:649:10)
10:59:15 at Promise._settlePromises (/node_modules/bluebird/js/release/promise.js:729:18)
10:59:15 at Promise._fulfill (/node_modules/bluebird/js/release/promise.js:673:18)
10:59:15 at /node_modules/bluebird/js/release/nodeback.js:42:21
10:59:15 at /node_modules/cypress/node_modules/universalify/index.js:22:54
```
I guess cypress-repeat should guard against this

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at cypress-repeat/index.js line 110 and reproduce the failed-start/no-results case described in the issue. Verify that this input no longer causes the reported TypeError and that the command completes without crashing.

Written by the indexing model from the issue text.

Assessment

Tech stack
cypress, javascript
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.