badoo / badoo/codeisok

Comments left in side-by-side mode on lines not part of diff become invisible in unified mode

Open
#90 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
PHP
Stars
84
Forks
14
PR merge metrics
No merged PRs in 30d

Description

**Steps to reproduce**

- Start review on a diff in side by side mode
- Leave a comment on a line not part of diff
- Finish review
- Pretend you are another developer and open review in unified mode

**Possible Solutions**

- Show review comments in unified mode even if their lines can't be found
- Don't allow adding review comments on lines which are not a part of the diff

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.