badoo / badoo/RIBs

GlobalActivationLevel should be SLEEPING when node is stopped.

Open
#345 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Kotlin
Stars
164
Forks
50
PR merge metrics
No merged PRs in 30d

Description

When node is stopped, it could still receive configuration changes. In that case, if transitionHandler is present, transitionAnimation would be triggered but, as UI is not there, will cause configuration to change but view wont exist.

How to solve:
Move globalActivationState to SLEEPING when node is stopped.
Check ActivityIntegrationPoint.

How to reproduce:

1. Create an activity with a rib tree that is a Parent with a button + 2 rib childs(RibA + RibB). RibA is default one.
2. In Container interactor bind some source( input,dependency...) to a configuration change use node.createDestroy{} scope.
3. From the parent button trigger a new activity, from that activity modify the source binded to configuration to push RibB.
4. Go back to initial activity.
5.
Expected Behaviour: RibB is present.
Actual Behaviour: No rib is present.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading ActivityIntegrationPoint and tracing how globalActivationState changes when a node is stopped. Reproduce the Parent/RibA/RibB flow described in the issue, including the configuration change from the second activity. Done means a stopped node is SLEEPING and returning to the initial activity shows RibB as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.