badoo / badoo/MVICore

Access to old state to NewsPublisher and PostProcessor

Open
#88 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Kotlin
Stars
1.3k
Forks
88
PR merge metrics
No merged PRs in 30d

Description

Current implementation of `NewsPublisher` and `PostProcessor` has a signature of `(Action, Effect, State) -> T?`, which can be somehow limiting, when you want to diff the previous and current state.
The common suggestion to update the signature to include the previous state, e.g. `(State, Action, Effect, State) -> T?`, which seems to be the best idea for now.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the NewsPublisher and PostProcessor definitions and their usages, then trace how the current state reaches their callbacks. Confirm the API impact of adding the previous state to the signature; done means both callbacks can receive previous and current state and the affected project checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.