badoo / badoo/Chatto

Improve performance by removing Blended Layers

Open
#54 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
4.6k
Forks
588
PR merge metrics
No merged PRs in 30d

Description

Hello,

Currently the TextBubbleView instances have clear background color, if you check device with "Color Blended Layers" option, you will see the red area around the messages,

First fix would be to update the background view ( and background view of the subviews , because otherwise textView still has non-opaque subviews ) of the TextBubbleView with the same color as the message container has itself.

This will change from this
![simulator screen shot mar 9 2016 5 35 04 pm](https://cloud.githubusercontent.com/assets/2391557/13642644/9ab511ae-e61d-11e5-91eb-dc42d1a60c1c.png)

To this
![simulator screen shot mar 9 2016 5 33 33 pm](https://cloud.githubusercontent.com/assets/2391557/13642652/9fad0fcc-e61d-11e5-83dd-c59d30ef44e2.png)

There is still red area in the TextBubbleView container view, because it has rounded-rect/image with alpha,
to go further and fix them, I`d suggest to use stretchable background image with no alpha, so the background color of the image = background color of the collectionView, then you can put the stretchable bubble image on this background and create a new image without an alpha , which then will be used as a background of the CollectionViewCell.

Contributor guide

Open the contributing guide

Research direction

Locate TextBubbleView, its subviews, the message container, and the TextBubbleView container view. First inspect how their backgrounds and bubble images are configured, then use the device's Color Blended Layers option to compare the current rendering. Done means the message bubbles retain their appearance while the red blended regions described in the issue are removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile, performance
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.