badoo / badoo/Chatto

Make scrollViewDidScroll in BaseChatViewController open

Open
#431 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
Swift
Stars
4.6k
Forks
588
PR merge metrics
No merged PRs in 30d

Description

Hello,

I was wondering if you could mark the function [scrollViewDidScroll](https://github.com/badoo/Chatto/blob/6389e667d342cde4a305469eb117ae702579b814/Chatto/Source/ChatController/BaseChatViewController%2BScrolling.swift#L109) in `BaseChatViewController` as open in order to override it in my custom ChatViewController?

Kind regards
Maxi

Contributor guide

Open the contributing guide

Research direction

Start in Chatto/Source/ChatController/BaseChatViewController+Scrolling.swift at the scrollViewDidScroll declaration linked in the issue. Check the surrounding BaseChatViewController API and confirm that a custom ChatViewController can override the method when it is open.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.